Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gitlab configuration #429

Closed
sbilello opened this issue Apr 8, 2021 · 3 comments · Fixed by #1516
Closed

Add gitlab configuration #429

sbilello opened this issue Apr 8, 2021 · 3 comments · Fixed by #1516
Labels
docs 📝 improvements or additions to docs on the docs site
Milestone
v0.12.0

Comments

@sbilello
Copy link

sbilello commented Apr 8, 2021

Please add documentation on how to use rover with Gitlab

https://www.apollographql.com/docs/rover/ci-cd/
@sbilello sbilello added the docs 📝 improvements or additions to docs on the docs site label Apr 8, 2021
@lrlna lrlna added the triage issues and PRs that need to be triaged label Apr 12, 2021
@lrlna lrlna mentioned this issue Apr 14, 2021
Closed
@JakeDawkins
Copy link
Contributor

@sbilello have you already set up Gitlab to use Rover and have something to share already that we can build off? I've never used Gitlab for CI and am just curious 😄

@lrlna lrlna removed the triage issues and PRs that need to be triaged label Apr 14, 2021
@lrlna lrlna added this to the June 22 milestone Apr 14, 2021
@sbilello
Copy link
Author

No! I didn't :) We use it in our CI/CD pipeline GitLab so I was trying to get this information to share with my infra team! Maybe you can spin up a docker container with gitlab https://docs.gitlab.com/omnibus/docker/

@abernix abernix modified the milestones: June 22, July 6, 2021 Jun 9, 2021
@EverlastingBugstopper EverlastingBugstopper modified the milestones: July 7, July 20 Jul 7, 2021
@EverlastingBugstopper EverlastingBugstopper modified the milestones: August 2, Qx Aug 4, 2021
@EverlastingBugstopper EverlastingBugstopper removed this from the Qx milestone Aug 17, 2021
Closed
@ugurcemozturk ugurcemozturk mentioned this issue Feb 15, 2023
Merged
@EverlastingBugstopper
Copy link
Contributor

fixed by #1513

@EverlastingBugstopper EverlastingBugstopper added this to the v0.12.0 milestone Feb 17, 2023
Merged
EverlastingBugstopper added a commit that referenced this issue Feb 17, 2023
@EverlastingBugstopper
release: v0.12.0 (#1516)
12a3f9f 
# [0.12.0] - 2023-02-17

## 🚀 Features

- **Allow `rover subgraph check` to execute without operation check
results - @jsegaran, #1490**

Apollo Studio now allows you to disable operation checks for a graph
variant. Older versions of Rover will fail to parse the result of a
check without a result for an operation check and return an error.
Running the same check in versions of Rover after 0.12.0 will succeed
when operation checks are disabled.

## 🛠 Maintenance

- **Fix up xtask test runner - @EverlastingBugstopper, #1505**

`cargo xtask test` detects failed tests and reruns them with some
arguments. Unfortunately the code to insert `--target` arguments was in
the wrong order and resulted in confusing internal error messages on
failed tests, this is now fixed.

## 📚 Documentation

- **Adds Gitlab CI/CD Instructions - @ugurcemozturk, #1513 fixes #429**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs 📝 improvements or additions to docs on the docs site
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

release: v0.12.0 apollographql/rover
5 participants
@abernix @sbilello @lrlna @JakeDawkins @EverlastingBugstopper