Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.8.0 installed from npm broken due to superfluous output on STDOUT #1198

Closed
kpachbiu88 opened this issue Jul 28, 2022 · 12 comments
Closed
Assignees
Labels
Milestone

Comments

@kpachbiu88
Copy link

kpachbiu88 commented Jul 28, 2022

In Rover version 0.8.0 add extra message in the schema and breaks it

Command: rover subgraph introspect https://api-test.test.com/main/graphql > test.graphql
Result test.graphql:

If you would like to disable Rover's anonymized usage collection, you can set APOLLO_TELEMETRY_DISABLED=1
You can check out our documentation at https://go.apollo.dev/r/docs.
rover.exe is already installed, skipping installation.
schema
  @link(url: "https://specs.apollo.dev/link/v1.0")
{
  query: Query
  mutation: Mutation
}

extend schema
  @link(url: "https://specs.apollo.dev/federation/v2.0", import: ["@key", "@shareable"])

directive @link(url: String, as: String, for: link__Purpose, import: [link__Import]) repeatable on SCHEMA

directive @key(fields: federation__FieldSet!, resolvable: Boolean = true) repeatable on OBJECT | INTERFACE

directive @federation__requires(fields: federation__FieldSet!) on FIELD_DEFINITION

directive @federation__provides(fields: federation__FieldSet!) on FIELD_DEFINITION

directive @federation__external(reason: String) on OBJECT | FIELD_DEFINITION

directive @federation__tag(name: String!) repeatable on FIELD_DEFINITION | OBJECT | INTERFACE | UNION | ARGUMENT_DEFINITION | SCALAR | ENUM | ENUM_VALUE | INPUT_OBJECT | INPUT_FIELD_DEFINITION

directive @federation__extends on OBJECT | INTERFACE

directive @shareable on OBJECT | FIELD_DEFINITION
....

This message breaks schema:
If you would like to disable Rover's anonymized usage collection, you can set APOLLO_TELEMETRY_DISABLED=1
You can check out our documentation at https://go.apollo.dev/r/docs.
rover.exe is already installed, skipping installation.

@kpachbiu88 kpachbiu88 added bug 🐞 triage issues and PRs that need to be triaged labels Jul 28, 2022
@rplinzner
Copy link

The issue breaks our production pipelines and we couldn't deploy a quick fix. Lost couple of hairs trying to figure it out. PLS fix.

@kpachbiu88
Copy link
Author

Temp solution install 0.7.0 version.
npm i @apollo/[email protected] -g

@rplinzner
Copy link

rplinzner commented Jul 28, 2022

@kpachbiu88 Yes, figured it out, thx

@radekmie
Copy link

Can confirm, the same happens to us.

@abernix abernix pinned this issue Jul 28, 2022
@abernix
Copy link
Member

abernix commented Jul 28, 2022

Thanks for opening this issue. Does this happen also to you all with the version installed from the curl installer? (Note: Specifically NOT from npm!).

In other words, the instruction at the top of the documentation here: https://www.apollographql.com/docs/rover/getting-started

@jazarja
Copy link

jazarja commented Jul 28, 2022

Also happened when composing supergraph

my command:

rover supergraph compose --config ./envs/supergraph-${{ env.ENVIRONMENT }}.yaml > schema.graphql

Why you guys need to display such annoying text when composing schema?

@abernix
Copy link
Member

abernix commented Jul 28, 2022

@jazarja The text is meant to be on STDERR and not interfere with the schema that's being generated. Also, I believe that text is just shown the first time you run Rover on an installation. If you run literally any other command first, that message might not appear? It looks to me like information from the installation step is bleeding into the output.

Out of curiosity, are you also installing Rover with npm? Or are you using the curl installer?

@radekmie
Copy link

@abernix I installed Rover CLI from npm (only there), but maybe had a curl version installed at some point too.

Also, I believe that text is just shown the first time you run Rover on an installation. If you run literally any other command first, that message might not appear? It looks to me like information from the installation step is bleeding into the output.

No, it's there every time.

@jazarja
Copy link

jazarja commented Jul 28, 2022

I install rover with npm on my github action (so it will always first time run whenever I run rover supergraph compose)

I can say the latest version has breaking change so the command to generate supergraph on https://www.apollographql.com/docs/rover/commands/supergraphs doesnt work anymore.

# Creates prod-schema.graphql or overwrites if it already exists
rover supergraph compose --config ./supergraph.yaml > prod-schema.graphql

@abernix
Copy link
Member

abernix commented Jul 28, 2022

Same question to everyone: can anyone confirm that the problem goes away with a version installed from curl instead of npm?

@radekmie
Copy link

It works correctly when installed using curl.

@abernix abernix changed the title In Rover version 0.8.0 add extra message in the schema and breaks it v0.8.0 installed from npm broken due to superfluous output on STDOUT Jul 28, 2022
@kevin-mitchell
Copy link

I believe this is related to #1197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants