Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgraph introspection response contains extraneous messaging that invalidates the schema. #1197

Closed
ryatama opened this issue Jul 27, 2022 · 1 comment · Fixed by #1199, #1200 or #1201
Closed
Assignees
Labels
Milestone

Comments

@ryatama
Copy link

ryatama commented Jul 27, 2022

Description

When using the latest release of Rover 0.8.0 via npx the 'rover is already installed' messaging displays as part of the schema output. My team just noticed this because we have Github actions configured to run the following to publish our changes:

npx -p @apollo/rover rover subgraph introspect https://our-server/api/graphql | rover subgraph publish Gateway@current --name app-name --routing-url https://our-server/api/graphql --schema -

The introspection call technically works, but the schema output is invalid because of the additional messaging added (see below).

This has worked previous to the most recent release (0.7.0)

Note: it still works when using the CLI downloaded via cURL, but running it with npx fails.

Steps to reproduce

Run npx -p @apollo/rover rover subgraph introspect YOUR_GRAPHQL_ENDPOINT > schema.graphql

Expected result

The output inside of schema.graphql should be a fully valid schema.

Actual result

The output inside of schema.graphql is an invalid schema and starts with the text:

If you would like to disable Rover's anonymized usage collection, you can set APOLLO_TELEMETRY_DISABLED=1
You can check out our documentation at https://go.apollo.dev/r/docs.
rover is already installed, skipping installation.

Environment

Rover Info:
Version: 0.8.0
Install Location: /Users/rkeenan/.rover/bin/rover
OS: Mac OS 11.6.1 [64-bit]
Shell: /bin/zsh
@ryatama ryatama added bug 🐞 triage issues and PRs that need to be triaged labels Jul 27, 2022
@kirk-marple
Copy link

Just wanted to add that our builds started failing earlier today too in a similar way.

We'll have to roll back to 0.7.0 to work around this, since the schema introspection is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment