feat(binstall): error on missing glibc

Author: EverlastingBugstopper

CHANGELOG.md

@@ -79,6 +79,17 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
   [EverlastingBugstopper]: https://github.com/EverlastingBugstopper
   [pull/472]: https://github.com/apollographql/rover/pull/472
 
+- **Curl installer returns error message on Linux if glibc is missing - [EverlastingBugstopper], [issue/393] [pull/494]**
+
+  Rover is currently built for the `unknown-linux-gnu` rustc target, which requires `glibc` >= 2.7 to be installed.
+  Previously, if you attempted to install Rover on a machine without `glibc`, you would get quite cryptic linker
+  errors. Now, users attempting to install Rover without the proper `glibc` install will get an error message
+  informing them.
+
+  [EverlastingBugstopper]: https://github.com/EverlastingBugstopper
+  [pull/494]: https://github.com/apollographql/rover/pull/494
+  [issue/393]: https://github.com/apollographql/rover/issues/393
+
 ## 🐛 Fixes
 
 - **Adds a newline to all output to stdout - [EverlastingBugstopper], [issue/458] [pull/462]**

installers/binstall/scripts/nix/install.sh

@@ -51,6 +51,9 @@ download_binary_and_run_installer() {
         *windows*)
             _ext=".exe"
             ;;
+        *linux*)
+            need_glibc
+            ;;
     esac
 
     local _tardir="rover-$DOWNLOAD_VERSION-${_arch}"
@@ -104,7 +107,7 @@ get_architecture() {
 
     if [ "$_ostype" = Darwin -a "$_cputype" = arm64 ]; then
         # Darwin `uname -s` doesn't seem to lie on Big Sur
-        # but we want to serve x86_64 binaries anyway that they can
+        # but we want to serve x86_64 binaries anyway so that they can
         # then run in x86_64 emulation mode on their arm64 devices
         local _cputype=x86_64
     fi
@@ -154,6 +157,12 @@ err() {
     exit 1
 }
 
+need_glibc() {
+    if ! check_cmd "/lib/x86_64-linux-gnu/libc.so.6"
+    then err "could not link against 'glibc'. Do you have glibc >= 2.7 installed?"
+    fi
+}
+
 need_cmd() {
     if ! check_cmd "$1"
     then err "need '$1' (command not found)"

installers/binstall/scripts/nix/local-install.sh

@@ -1,3 +1,11 @@
+# Licensed under the MIT license
+# <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+# option. This file may not be copied, modified, or distributed
+# except according to those terms.
+
+# This is just a little script that can be downloaded from the internet to
+# install rover. It just downloads the installer and runs it.
+
 # version found in Rover's Cargo.toml
 # Note: this line is built automatically
 # in build.rs. Don't touch it!
@@ -65,14 +73,8 @@ function Initialize-Environment() {
     break
   }
 
-  If (-Not (Get-Command 'curl')) {
-    Write-Error "The curl command is not installed on this machine. Please install curl before installing Rover"
-    # don't abort if invoked with iex that would close the PS session
-    If ($myinvocation.mycommand.commandtype -eq 'Script') { return } else { exit 1 }
-  }
-
   If (-Not (Get-Command 'tar')) {
-    Write-Error "The tar command is not installed on this machine. Please install curl before installing Rover"
+    Write-Error "The tar command is not installed on this machine. Please install tar before installing Rover"
     # don't abort if invoked with iex that would close the PS session
     If ($myinvocation.mycommand.commandtype -eq 'Script') { return } else { exit 1 }
   }