Skip to content

Commit 72fcc33

Browse files
feat: removes -V from subcommands + strict utf-8 (#487)
1 parent e7026ff commit 72fcc33

File tree

2 files changed

+29
-6
lines changed

2 files changed

+29
-6
lines changed

CHANGELOG.md

+20-4
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,32 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
66

77
<!-- # [x.x.x] (unreleased) - 2021-mm-dd
88
> Important: X breaking changes below, indicated by **❗ BREAKING ❗**
9-
## 🚀 Features
109
## ❗ BREAKING ❗
10+
## 🚀 Features
1111
## 🐛 Fixes
1212
## 🛠 Maintenance
1313
## 📚 Documentation -->
1414

15-
# [x.x.x] (unreleased) - 2021-mm-dd
16-
> Important: X breaking changes below, indicated by **❗ BREAKING ❗**
17-
## 🚀 Features
15+
# [0.0.11] (upcoming) - 2021-05-11
16+
> Important: 1 breaking change below, indicated by **❗ BREAKING ❗**
1817
## ❗ BREAKING ❗
18+
19+
- **Removes -V/--version flag from subcommands - [EverlastingBugstopper], [pull/487]**
20+
21+
Rover's subcommands will always be the same version as Rover, so we no longer accept `-V` or `--version`
22+
on Rover's subcommands.
23+
24+
[EverlastingBugstopper]: https://github.com/EverlastingBugstopper
25+
[pull/487]: https://github.com/apollographql/rover/pull/487
26+
27+
- **Disallow all non-UTF-8 argument values - [EverlastingBugstopper], [pull/487]**
28+
29+
Rover will no longer accept any argument values that cannot be properly interpreted as UTF-8.
30+
31+
[EverlastingBugstopper]: https://github.com/EverlastingBugstopper
32+
[pull/487]: https://github.com/apollographql/rover/pull/487
33+
34+
## 🚀 Features
1935
## 🐛 Fixes
2036
## 🛠 Maintenance
2137

src/cli.rs

+9-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use serde::Serialize;
2-
use structopt::StructOpt;
2+
use structopt::{clap::AppSettings, StructOpt};
33

44
use crate::command::{self, RoverStdout};
55
use crate::utils::{
@@ -17,7 +17,14 @@ use timber::{Level, LEVELS};
1717
use camino::Utf8PathBuf;
1818

1919
#[derive(Debug, Serialize, StructOpt)]
20-
#[structopt(name = "Rover", global_settings = &[structopt::clap::AppSettings::ColoredHelp], about = "
20+
#[structopt(
21+
name = "Rover",
22+
global_settings = &[
23+
AppSettings::ColoredHelp,
24+
AppSettings::StrictUtf8,
25+
AppSettings::VersionlessSubcommands,
26+
],
27+
about = "
2128
Rover - Your Graph Companion
2229
Read the getting started guide by running:
2330

0 commit comments

Comments
 (0)