-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust plugin order to correct interaction with telemetry & traffic shaping #6757
base: dev
Are you sure you want to change the base?
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: d1282191da5adf43979ca34d |
@goto-bus-stop, please consider creating a changeset entry in |
Migrate to new test harness. Fix add missing tests.
@@ -27,6 +26,7 @@ pub(crate) struct CSRFConfig { | |||
/// set unsafe_disabled = true to disable the plugin behavior | |||
/// Note that setting this to true is deemed unsafe. | |||
/// See <https://developer.mozilla.org/en-US/docs/Glossary/CSRF>. | |||
/// TODO rename this to enabled. This is in line with the other plugins and will be less confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be done before merging this PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, 2.n or 3.0
This requires that an extra header is sent to allow it to pass cors.
Follow-ups (Maybe for router 2.0.1 if necessary):