Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric when a retry occurs #2736

Closed
bnjjj opened this issue Mar 10, 2023 · 1 comment · Fixed by #2829
Closed

Add metric when a retry occurs #2736

bnjjj opened this issue Mar 10, 2023 · 1 comment · Fixed by #2829
Assignees
@Geal

Comments

@bnjjj
Copy link
Contributor

bnjjj commented Mar 10, 2023 •
edited
Loading

Regarding the experimental retry https://www.apollographql.com/docs/router/configuration/traffic-shaping/ - is there a way to get logging / metrics on when the retries occur, in order to gain more insight, and adjust params if needed?

Originally posted by @nikola-mladenovic in #2734
@deweyjose
Copy link
Contributor

This will be extremely helpful operational signal as the the health our our subgraph ecosystem.

@Geal Geal mentioned this issue Mar 22, 2023
Merged
6 tasks
Geal added a commit that referenced this issue Mar 23, 2023
@Geal @BrynCooke
add events tracking subgraph requests retry and break (#2829)
77fe2e6 
Fix #2518
Fix #2736

New metrics tracking retries:
- `apollo_router_subgraph_request_retry_break_count`
- `apollo_router_subgraph_request_retry_attempt_count`

New spans:
- `receive_body` tracking the time spent receiving the request body
(debug level)

the GraphQL query and operation name are removed from the query planning span because they are already present in the supergraph span.

---------

Co-authored-by: Bryn Cooke <[email protected]>
@abernix abernix mentioned this issue Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geal Geal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add events tracking subgraph requests retry and break apollographql/router
3 participants
@Geal @bnjjj @deweyjose