Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Bumping graphql-tag, ignoring deprecation warnings #498

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

jnwng
Copy link
Contributor

@jnwng jnwng commented Mar 2, 2017

graphql-tag has deprecated the export of the printer export (which we use for various AST-related tasks here in react-apollo). when graphql-tag@v2 comes out, we can switch to using the printer / parser from the graphql package, but for now we know about the deprecation warning and can safely ignore it.

addresses graphql-tag#54

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@helfer
Copy link
Contributor

helfer commented Mar 3, 2017

Thanks @jnwng

@helfer helfer merged commit a0050a3 into apollographql:master Mar 3, 2017
@helfer
Copy link
Contributor

helfer commented Mar 3, 2017

Actually, I'm afraid this didn't completely fix the problem. Let me check again.

edit: nvm, this was coming from another package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants