This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Fix an error that the networkStatus did not change to ready at the end of pagination #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mu29: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
mu29
changed the title
|
Have you signed the agreement @mu29 ? I need this fix 🙂 |
|
Sure :) As you can see, all checks have passed. |
mu29
force-pushed
the
fix/last-page-pagination
branch
from
e289c52 to
732d430
Compare
hwillson
added a commit
to apollographql/apollo-client
that referenced
this pull request
Oct 2, 2019
hwillson
added a commit
to apollographql/apollo-client
that referenced
this pull request
Oct 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3468
Although #3433 has improved performance by reducing the number of renders in pagination, it only works when the fetchMore function returns a new list.
If we reached to the end of the list, the fetchMore function returns the same length of result, which is determined as equal by the @wryware/equality library we currently use. Therefore, reading the last page of the list remains
networkStatustoNetworkStatus.fetchMore.I think apollo-client needs to send the updated fetchMore result and the changed networkStatus at once.