Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Improve subscribeToMore types #2093

Closed
wants to merge 2 commits into from
Closed

Improve subscribeToMore types #2093

wants to merge 2 commits into from

Conversation

skovy
Copy link
Contributor

@skovy skovy commented Jun 11, 2018

Improve the types for subscribeToMore (specifically updateQuery for the issue below) and add temporary types not yet released in apollo-client. When these type improvements are released for apollo-client all of these types will be directly replaceable.

This should resolve this issue in the apollo-client repo: apollographql/apollo-client#3391.

There are already "temporary" types that have these. This issue #2092 was created to clean these up when the next version of apollo-client is released and the peerDependency is updated for react-apollo.

@ghost ghost added the typescript label Jun 11, 2018
This was referenced Jun 11, 2018
Closed
Closed
@skovy skovy mentioned this pull request Aug 13, 2018
Merged
@skovy
Copy link
Contributor Author

skovy commented Aug 13, 2018

This PR is no longer relevant after #2281

@skovy skovy closed this Aug 13, 2018
@skovy skovy deleted the skovy/improve-subscribe-to-more-types branch August 13, 2018 03:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skovy