-
Notifications
You must be signed in to change notification settings - Fork 787
Add client
to Query
's QueryResult
#1488
Add client
to Query
's QueryResult
#1488
Conversation
Generated by 🚫 dangerJS |
|
Someone needs to hit rebuild on travis later. This is good to go. EDIT: seems like the build allowed it regardless of bundlesize. |
I'm wondering if it is really necessary to add the The improvements to the test are great! Thanks so much, it is organized much better now:) |
Yes, it is a big improvement for me (my code is already converted). I have several render call backs so just another adds to the nesting, and with 30 components that are mutations + queries, it's just more cruft when I know the client is there. The beauty of this pattern is that the user can take or leave it. They can choose to destructure it here or from ApolloConsumer. |
client
toQuery
'sQueryResult
to prevent the need for query + mutation components to need to require eitherApolloConsumer
orwithApollo
client
inQueryResult
testonly
tojest
client
Query.test
based on grouped describe contexts