-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(descriptors): add support for descriptors #99
Conversation
Looks good to me. |
test.js
Outdated
} | ||
`; | ||
|
||
assert.equal(ast.definitions[0].description, 'This is a descriptor'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to add an assertion on the second descriptor too.
@dyst5422, thanks for the feedback! I added more tests to cover type and field descriptors. |
thank you @jamiter! |
@jnwng, you're welcome, thanks for merging! I see I didn't update the changelog though. Is that something you like to do yourself? Seems 2.3.0 is also missing. Not sure what's in there. |
ah sorry, i pushed to `origin` instead of `upstream` — you should see the
updated changelog in master now.
…On Fri, Jun 16, 2017 at 11:52 AM Michiel ter Reehorst < ***@***.***> wrote:
@jnwng <https://github.com/jnwng>, you're welcome, thanks for merging! I
see I didn't update the changelog though. Is that something you like to do
yourself? Seems 2.3.0 is also missing. Not sure what's in there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABERRoGKJks-iwoytkjvio7L0eFxMdAFks5sEs7kgaJpZM4N7Pg1>
.
|
Will you be tagging a release on this? Would love to pull it down and start seeing my descriptors. |
@dyst5422 this is in [email protected] on npm, but i did just notice that the tags i'm creating locally haven't been pushed. will update that when i get a chance. |
Just an idea: we could add a |
Thanks for the heads up. Could it be an issue with |
…ographql#99)"" This reverts commit c55ca40.
Connects to #81
This will add support for descriptors in schema files:
@stubailo, could you have a look at this? Or maybe @jnwng. Thanks!