Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loader to work with source files using any EOL separators #93

Closed
wants to merge 1 commit into from

Conversation

iki
Copy link

@iki iki commented Jun 6, 2017

Source EOL separators do not need to match OS default EOL separator. For example, it's common in Git for WIndows to commit LF and checkout as-is, so the source files do use LF (\n), and not CRLF (\r\n).

Source EOL separators do not need to match OS default EOL separator. For example, it's common in Git for WIndows to commit LF and checkout as-is, so the source files do use LF (\n), and not CRLF (\r\n).
@apollo-cla
Copy link

@iki: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@jnwng
Copy link
Contributor

jnwng commented Jun 6, 2017

thank you @iki - i'm going to close this as a duplicate of #95 (since they both accomplish the same goal). i chose #95 because this issue looks like its affecting a lot of people and we need you to sign the CLA before we can land changes and i want to get this out promptly.

i do want to thank you for contributing though!

@jnwng jnwng closed this Jun 6, 2017
@jnwng jnwng added the duplicate label Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants