Support use case of gql() vs gql
#66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewerwin: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
@matthewerwin thanks for the PR! do you mind adding a test for this so we don't regress in the future? (also, you may need to rebase to reflect the changes that came with #60) |
|
@jnwng thanks for the comments. Will do -- sorry for the delay...crazy week over here! |
Current implementation throws an exception that the query isn't valid without providing information that the document was reduced to a single character by the implementation. Either the software should elegantly handle the case when parenthesis are added to the function call or else return a useful error on usage.
|
thank you @matthewerwin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation throws an exception that the query isn't valid without providing information that the document was reduced to a single character by the implementation. Either the software should elegantly handle the case when parenthesis are added to the function call or else return a useful error on usage.