Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for graphql@14 #211

Merged
merged 5 commits into from
Oct 2, 2018
Merged

Adding support for graphql@14 #211

merged 5 commits into from
Oct 2, 2018

Conversation

jnwng
Copy link
Contributor

@jnwng jnwng commented Sep 13, 2018

Will open this against #210 — making sure that this is passing integration before spamming that branch.

graphql@14 is a major breaking change because they [no longer support the same engines]

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jnwng! Are you planning on committing these changes back into #210? I'd like to get this merged sooner than later.

package.json Outdated Show resolved Hide resolved
@jnwng
Copy link
Contributor Author

jnwng commented Sep 14, 2018

yep @hwillson im planning on merging into #210, just wanted to run the CI here to make sure it would work properly.

it's worth noting that #196 has been merged but not released, because it turns out it's a major breaking change to TypeScript users as well, adding to my desire to bump the major

@hwillson
Copy link
Member

Thanks for the update @jnwng. I was hoping we didn't have to force people to use graphql@14, but if #196 is a breaking change, then a major version bump sounds like a good idea to me. Thanks for looking into this!

jnwng added 3 commits October 1, 2018 22:28
This reverts commit ae792b6. Based on #196 and #150, introducing the `DocumentNode` return value causes this library to break for existing TypeScript installations. I'm reverting this temporarily so we can release support for GraphQL v14 in a minor patch, and if we can't fix the TypeScript configuration, we'll release a major version with this commit back in.
@jnwng jnwng merged commit 27fdc8a into master Oct 2, 2018
@jnwng jnwng deleted the jw/graphql-14 branch October 2, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants