-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix operations with fragments in the Webpack loader for IE 11 #190
Conversation
@rocwang: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Hello, I have the same problem in the Internet Explorer 11. My websiste uses fragments in many places and to corret the problems I need of this correction. Are you planning to make this fix available in a version of lib that I can use with yarn ? |
Facing the same problem. Any idea when, if ever, this pull request will be accepted? |
Hello @rocwang you make this process ? I really need to make this fix available =S |
@gabrielpieta I've just done that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems reasonable enough to me. It is very true that IE11 does not allow constructor arguments.
Please try |
Wooooow, thanks man, I go try and report here! |
@abernix Can you update CHANGELOG.md and push the tag of v2.10.1? |
Done and done. Thanks, @gfx. |
Pull Request Labels
/label bug
I was using version 2.9.2 with the Webpack loader. On IE 11, I saw the following error:
It turns out that on line 133 of loader.js, we have
var newRefs = new Set(opRefs);
and IE 11 doesn't support "new Set(iterable)", so I rewrite it to add the members of opRefs to newRefs one by one usingforEach
, which resovles the issue.