Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operations with fragments in the Webpack loader for IE 11 #190

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

rocwang
Copy link
Contributor

@rocwang rocwang commented Jun 8, 2018

Pull Request Labels

  • feature
  • blocking
  • docs

/label bug

I was using version 2.9.2 with the Webpack loader. On IE 11, I saw the following error:

Fragment was XXX used, but not defined

It turns out that on line 133 of loader.js, we have var newRefs = new Set(opRefs); and IE 11 doesn't support "new Set(iterable)", so I rewrite it to add the members of opRefs to newRefs one by one using forEach, which resovles the issue.

@apollo-cla
Copy link

@rocwang: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost added the bug label Jun 8, 2018
@gabrielpieta
Copy link

Hello,

I have the same problem in the Internet Explorer 11. My websiste uses fragments in many places and to corret the problems I need of this correction.

Are you planning to make this fix available in a version of lib that I can use with yarn ?

@FernandoBasso
Copy link

Facing the same problem. Any idea when, if ever, this pull request will be accepted?

@gabrielpieta
Copy link

@rocwang: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Hello @rocwang you make this process ? I really need to make this fix available =S

@rocwang
Copy link
Contributor Author

rocwang commented Jan 14, 2019

@gabrielpieta I've just done that.

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems reasonable enough to me. It is very true that IE11 does not allow constructor arguments.

@abernix abernix merged commit d4fabb9 into apollographql:master Jan 17, 2019
@abernix
Copy link
Member

abernix commented Jan 17, 2019

Please try [email protected] and see if this is resolved.

@gabrielpieta
Copy link

Wooooow, thanks man, I go try and report here!

@gfx
Copy link

gfx commented Jan 18, 2019

@abernix Can you update CHANGELOG.md and push the tag of v2.10.1?

abernix added a commit that referenced this pull request Jan 18, 2019
With the only note being the fix provided in #190.

Ref: #190
@abernix
Copy link
Member

abernix commented Jan 18, 2019

Done and done. Thanks, @gfx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants