Typescript type safety

[felixfbecker]

Closes #138

I used the broadest possible version range for @types/graphql that exports DocumentNode to get the biggest chance of deduping.

Also changed the string tag signature to not use any, like String.raw.

[apollo-cla]

@felixfbecker: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[tgriesser]

0.12.x should also export DocumentNode, how about >=0.8.6

[felixfbecker]

At the time I opened this PR 0.12 didn't exist, will update.
I don't understand the second question? 0.8.6 was the first version to export it

[tgriesser]

I meant that by just specifying the dependency as "@types/graphql": ">=0.8.6", and omitting the <=x.x.x the right hand side won't continue to need to be bumped each time a release is cut.

[felixfbecker]

How do you know the next version does not contain a breaking change? It doesn't have to be bumped every time a release is cut, it's an interface so it will work fine if you use a different version in your project that is compatible

[4F2E4A2E]

@felixfbecker did you sign the agreement?
Will this PR request be accepted any time soon? Is there help needed?
We hope to be able to create queries directly in typescript by this.

[felixfbecker]

Yes I did. I cant tell you if this will get merged anytime soon. Seems like nobody is maintaining this project

[jnwng]

thank you!

[4F2E4A2E]

@felixfbecker can you provide an example?

[felixfbecker]

Thanks @jnwng!
@4F2E4A2E Sorry, what do you want an example for?

[jnwng]

live in [email protected]

[paulcpk]

Interpreting the question by @4F2E4A2E:

@felixfbecker can you provide an example?

@felixfbecker Could you provide an example of how gql is now able to generate type safe graphQL queries, as proposed in #138?

Thanks a lot! 😃

[4F2E4A2E]

@felixfbecker just got a closer look at your pr => it was about the return value and not about type safe queries. Sorry for that. Anyway, it seams not to be possible right, but i ask anyway, do someone know a way to define graphql queries type safe with typescript?

[felixfbecker]

@4F2E4A2E there is a TypeScript language service plugin that gives you autocompletion for fields and you can generate typings for the return types of queries. Not aware of other solutions.

[4F2E4A2E]

@felixfbecker thanks, do you mean the visual code plugin? Have checked that out already, it's only for vs. I am looking for a ts solution which can be validate via type safty.

[felixfbecker]

No, I am talking about https://github.com/Quramy/ts-graphql-plugin. This is getting a bit off topic here, I would suggest you move this over to StackOverflow or Gitter if you need more help

[4F2E4A2E]

StackOverflow is great thanks, but that link is what i meant by visual code => no that's not it, I am looking for a type safe way to write graphql queries via typescript. Thanks anyway 👍

[felixfbecker]

That link is not a Visual Studio Code plugin. It's a TypeScript language service plugin. You define it in tsconfig.json. It will work with any editor that uses the TypeScript language service, e.g. Atom or Sublime.