Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename github actions and make shield specific. #160

Merged
merged 3 commits into from
Sep 16, 2020
Merged

Conversation

Enrico2
Copy link
Contributor

@Enrico2 Enrico2 commented Sep 16, 2020

Clarify in our README what each badge stands for, and add a netlify badge (which will stop failing once #158 is merged)

closes #149

@Enrico2 Enrico2 requested a review from abernix September 16, 2020 18:31
@Enrico2 Enrico2 marked this pull request as ready for review September 16, 2020 18:31
@Enrico2 Enrico2 linked an issue Sep 16, 2020 that may be closed by this pull request
@Enrico2 Enrico2 merged commit 83bb179 into main Sep 16, 2020
@Enrico2 Enrico2 deleted the ran/fix_badges branch September 16, 2020 18:43
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@Enrico2
Copy link
Contributor Author

Enrico2 commented Sep 16, 2020

@abernix Sorry for jumping the gun! I thought you're out for the day. I also want to fix the links. Good suggestions! Fixing now.

@Enrico2
Copy link
Contributor Author

Enrico2 commented Sep 16, 2020

@abernix fixed in main 2f799fa

abernix added a commit that referenced this pull request Sep 21, 2020
For me, this made the URL fully recognizable/clickable in the browser on GitHub (and in my terminal), rather than stopping at the `(`.

Relates to #160.
@abernix
Copy link
Member

abernix commented Sep 21, 2020

LGTM, @Enrico2! I added one more commit which applied it to the other parens in the SVG badge URL, directly to main: 45b4f13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[js-repo-migration] Prefix Rust GitHub Actions
2 participants