This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
rewrite "external" urls pointing to the current domain into internal urls #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-monodocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
phryneas
commented
Jan 23, 2024
src/utils/index.js
Outdated
| @@ -7,7 +7,13 @@ import {withPrefix} from 'gatsby'; | |||
| export const NavContext = createContext(); | |||
| export const PathContext = createContext(); | |||
|
|
|||
| export const isUrl = string => /^https?:\/\//.test(string); | |||
| const urlRegex = /^https?:\/\//; | |||
There was a problem hiding this comment.
I moved those out into constants to the regex is not recreated for every call and can be optimized by the engine.
12 tasks
jerelmiller
approved these changes
Jan 23, 2024
|
I've double-checked this and it will need another fix - see https://deploy-preview-719--apollo-monodocs.netlify.app/react/api/core/ApolloClient#ApolloClientOptions
This link currently ends up as |
phryneas
force-pushed
the
pr/externalUrlCheck
branch
from
05ee41b to
f59f877
Compare
phryneas
changed the title
|
Okay, fixed up and requesting a re-review :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are reusing comments between source code and docs, our linked urls are absolute (otherwise they couldn't be used from the IDE), not relative.
The currentisExternalcheck recognizes these links to the docs as "external" and opens them in a new tab - this PR aims to fix that.See apollographql/apollo-client#11381 (comment)
This now rewrites urls into domain-absolute urls that will correctly be picked up by the
GatsbyLinkcomponent for internal documentation.See the deploy preview at https://65b114d41ee09600089b6792--apollo-monodocs.netlify.app/react/api/core/ApolloClient/#ApolloClientOptions