Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version of subscriptions-transport-ws for graphiql #983

Conversation

baconz
Copy link
Contributor

@baconz baconz commented Apr 24, 2018

The newer subscription client has a more forgiving default ka timeout

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@baconz: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@abernix
Copy link
Member

abernix commented Apr 24, 2018

Thanks, @baconz. If you can sign the CLA we can merge this.

@baconz baconz force-pushed the upgrade-subscription-transport-ws-for-graphiql branch 2 times, most recently from fbc79fe to f2d6e14 Compare April 25, 2018 15:26
@NeoPhi
Copy link
Contributor

NeoPhi commented May 8, 2018

@abernix Any chance this can be merged and released?

@hwillson
Copy link
Member

Hi @NeoPhi @baconz - we're ready to get this merged, but I just noticed you've released a newer 0.9.9 version of subscriptions-transport-ws. Did you want to update to the newer version first?

The newer subscription client has a more forgiving default ka timeout
@baconz baconz force-pushed the upgrade-subscription-transport-ws-for-graphiql branch from e94a693 to ba43643 Compare May 11, 2018 03:38
@baconz
Copy link
Contributor Author

baconz commented May 11, 2018

@hwillson makes sense, I bumped to 0.9.9!

@hwillson
Copy link
Member

Thanks @baconz - merging now (and we'll make sure these changes get added to the upcoming Apollo Server 2.0 version).

@hwillson hwillson merged commit c5d0c43 into apollographql:master May 11, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants