Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration: start of an editing pass #6687

Merged
merged 19 commits into from
Jul 22, 2022
Merged

migration: start of an editing pass #6687

merged 19 commits into from
Jul 22, 2022

Conversation

glasser
Copy link
Member

@glasser glasser commented Jul 14, 2022

No description provided.

@glasser glasser requested a review from trevor-scheer July 14, 2022 22:56
@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 96401a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 14, 2022 •
edited
Loading

✅ Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit 96401a1
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/62d9e76571909b00099e9f1a
😎 Deploy Preview https://deploy-preview-6687--apollo-server-docs.netlify.app/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 14, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 96401a1:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@glasser glasser force-pushed the glasser/migration-editing branch from a8bf112 to 84e3a52 Compare July 15, 2022 23:54
@glasser glasser force-pushed the glasser/migration-editing branch from 84e3a52 to ee3fb41 Compare July 19, 2022 16:49
rkoron007
rkoron007 suggested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@rkoron007 rkoron007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of suggested changes :)

docs/source/migration.mdx Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
@glasser glasser mentioned this pull request Jul 20, 2022
Closed
rkoron007
rkoron007 suggested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the batch of suggestions, will work on finishing this up soon (as well as reviewing the new content in later commits)!

docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Show resolved Hide resolved
docs/source/migration.mdx Show resolved Hide resolved
docs/source/migration.mdx Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
@glasser glasser mentioned this pull request Jul 20, 2022
Closed
rkoron007
rkoron007 suggested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third batch of review suggestions, only one more batch to go!

docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
rkoron007
rkoron007 suggested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final batch of my first review pass!

docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
rkoron007
rkoron007 reviewed Jul 21, 2022
View reviewed changes
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responses to feedback!

docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
glasser and others added 5 commits July 21, 2022 15:21
@glasser @rkoron007
Apply suggestions from code review
22e7d12 
Co-authored-by: Rose M Koron <[email protected]>
@glasser
Tweak gql section
db06120 
including re-adding triple-quotes because GH suggestions don't like
them. And I guess trimming trailing newlines which I guess my editor
does and which got introduced recently?
@glasser
Simplify some bullets and add body-parser/cors section back
90dc930
@glasser
A few @trevor-scheer related changes
36307f9
@glasser @rkoron007
Apply suggestions from code review
d7dc6a8 
Co-authored-by: Rose M Koron <[email protected]>
@glasser
Copy link
Member Author

glasser commented Jul 22, 2022

More TODOs to deal with on the branch (and @trevor-scheer should still take a pass) but this is good to merge for now!

@glasser glasser merged commit 940fac0 into version-4 Jul 22, 2022
@glasser glasser deleted the glasser/migration-editing branch July 22, 2022 00:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trevor-scheer trevor-scheer trevor-scheer left review comments

@rkoron007 rkoron007 rkoron007 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glasser @trevor-scheer @rkoron007 @IvanGoncharov