-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add errors details to didEncounterErrors hook #6558
Add errors details to didEncounterErrors hook #6558
Conversation
@b1zzu: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
✅ Deploy Preview for apollo-server-docs canceled.Built without sensitive environment variables
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit da95b68:
|
This seems like it would be a backwards-incompatible change so it probably isn't appropriate for AS3. We've reworked our error handling code a lot on the @IvanGoncharov any thoughts? |
(Or something like passing didEncounterErrors two arguments: the unformatted and formatted errors? (Or maybe the second argument would be an options object containing the formatted errors and maybe more stuff later)) |
Implement fix proposed in apollographql#6558 but implement it on top of AS4 Also contain some cleanup and refactoring related to apollographql#6355
Implement fix proposed in apollographql#6558 but implement it on top of AS4 Also contain some cleanup and refactoring related to apollographql#6355
Implement fix proposed in apollographql#6558 but implement it on top of AS4 Also contain some cleanup and refactoring related to apollographql#6355
Implement fix proposed in apollographql#6558 but implement it on top of AS4 Also contain some cleanup and refactoring related to apollographql#6355
In case an error is a
SyntaxError
orValidationError
this information is not passed to thedidEncounterErrors
hook. This missing piece of information is very important for logging plugins that may use it as a filter key to creating better metrics and monitoring alerts.