Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency fast-json-stringify to v3 - autoclosed #5985

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 3, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
fast-json-stringify ^2.7.6 -> ^3.0.0 age adoption passing confidence

Release Notes

fastify/fast-json-stringify

v3.0.0

Compare Source

What's Changed

New Contributors

Full Changelog: fastify/fast-json-stringify@v2.7.13...v3.0.0

v2.7.13

Compare Source

What's Changed

New Contributors

Full Changelog: fastify/fast-json-stringify@v2.7.12...v2.7.13

v2.7.12

Compare Source

What's Changed

New Contributors

Full Changelog: fastify/fast-json-stringify@v2.7.11...v2.7.12

v2.7.11

Compare Source

What's Changed

New Contributors

Full Changelog: fastify/fast-json-stringify@v2.7.10...v2.7.11

v2.7.10

Compare Source

What's Changed

New Contributors

Full Changelog: fastify/fast-json-stringify@v2.7.9...v2.7.10

v2.7.9

Compare Source

What's Changed

New Contributors

Full Changelog: fastify/fast-json-stringify@v2.7.8...v2.7.9

v2.7.8

Compare Source

What's Changed

New Contributors

Full Changelog: fastify/fast-json-stringify@v2.7.7...v2.7.8

v2.7.7

Compare Source

📚 PR:

  • Bump fastify/github-action-merge-dependabot from 2.1.0 to 2.1.1 (#​336)
  • Update README.md (#​337)
  • Fix minimizer renaming functions (#​339)

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the 🎄 dependencies Updates to dependencies, generally automatically managed by Renovate. label Jan 3, 2022
@renovate renovate bot force-pushed the renovate/fast-json-stringify-3.x branch from 597466c to 2605e89 Compare January 5, 2022 01:10
@Derelict98
Copy link

Good

@glasser
Copy link
Member

glasser commented Jan 5, 2022

Huh. fast-json-stringify is used only in one package and only to produce the constant strings '{"status":"fail"}' and '{"status":"pass"}'. Rather than read the changelog I'm just going to drop the dependency.

@Derelict98 , I hope this is "Good" too.

glasser added a commit that referenced this pull request Jan 5, 2022
This package was being used only to stringify two small constant
objects. It has a major version update available and rather than
evaluate the CHANGELOG, we might as well just not use it.

(Honestly I think it would be fine to just use JSON.stringify here; I
don't see any justification in #1971 for why this particular use case
requires a faster stringification than all the other JSON
stringification we do in Apollo Server. But just in case this matters to
anybody, I went with the fastest possible way of converting a constant
object to string.)

This should replace #5985.
glasser added a commit that referenced this pull request Jan 5, 2022
This package was being used only to stringify two small constant
objects. It has a major version update available and rather than
evaluate the CHANGELOG, we might as well just not use it.

(Honestly I think it would be fine to just use JSON.stringify here; I
don't see any justification in #1971 for why this particular use case
requires a faster stringification than all the other JSON
stringification we do in Apollo Server. But just in case this matters to
anybody, I went with the fastest possible way of converting a constant
object to string.)

This should replace #5985.
@renovate renovate bot force-pushed the renovate/fast-json-stringify-3.x branch from 2605e89 to eb55074 Compare January 5, 2022 22:00
glasser added a commit that referenced this pull request Jan 5, 2022
This package was being used only to stringify two small constant
objects. It has a major version update available and rather than
evaluate the CHANGELOG, we might as well just not use it.

(Honestly I think it would be fine to just use JSON.stringify here; I
don't see any justification in #1971 for why this particular use case
requires a faster stringification than all the other JSON
stringification we do in Apollo Server. But just in case this matters to
anybody, I went with the fastest possible way of converting a constant
object to string.)

This should replace #5985.
glasser added a commit that referenced this pull request Jan 5, 2022
This package was being used only to stringify two small constant
objects. It has a major version update available and rather than
evaluate the CHANGELOG, we might as well just not use it.

(Honestly I think it would be fine to just use JSON.stringify here; I
don't see any justification in #1971 for why this particular use case
requires a faster stringification than all the other JSON
stringification we do in Apollo Server. But just in case this matters to
anybody, I went with the fastest possible way of converting a constant
object to string.)

This should replace #5985.
@renovate renovate bot changed the title chore(deps): update dependency fast-json-stringify to v3 chore(deps): update dependency fast-json-stringify to v3 - autoclosed Jan 5, 2022
@renovate renovate bot closed this Jan 5, 2022
@renovate renovate bot deleted the renovate/fast-json-stringify-3.x branch January 5, 2022 22:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🎄 dependencies Updates to dependencies, generally automatically managed by Renovate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants