-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency fast-json-stringify to v3 - autoclosed #5985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
added
the
🎄 dependencies
Updates to dependencies, generally automatically managed by Renovate.
label
Jan 3, 2022
renovate
bot
force-pushed
the
renovate/fast-json-stringify-3.x
branch
from
January 5, 2022 01:10
597466c
to
2605e89
Compare
Good |
Huh. fast-json-stringify is used only in one package and only to produce the constant strings @Derelict98 , I hope this is "Good" too. |
glasser
added a commit
that referenced
this pull request
Jan 5, 2022
This package was being used only to stringify two small constant objects. It has a major version update available and rather than evaluate the CHANGELOG, we might as well just not use it. (Honestly I think it would be fine to just use JSON.stringify here; I don't see any justification in #1971 for why this particular use case requires a faster stringification than all the other JSON stringification we do in Apollo Server. But just in case this matters to anybody, I went with the fastest possible way of converting a constant object to string.) This should replace #5985.
glasser
added a commit
that referenced
this pull request
Jan 5, 2022
This package was being used only to stringify two small constant objects. It has a major version update available and rather than evaluate the CHANGELOG, we might as well just not use it. (Honestly I think it would be fine to just use JSON.stringify here; I don't see any justification in #1971 for why this particular use case requires a faster stringification than all the other JSON stringification we do in Apollo Server. But just in case this matters to anybody, I went with the fastest possible way of converting a constant object to string.) This should replace #5985.
renovate
bot
force-pushed
the
renovate/fast-json-stringify-3.x
branch
from
January 5, 2022 22:00
2605e89
to
eb55074
Compare
glasser
added a commit
that referenced
this pull request
Jan 5, 2022
This package was being used only to stringify two small constant objects. It has a major version update available and rather than evaluate the CHANGELOG, we might as well just not use it. (Honestly I think it would be fine to just use JSON.stringify here; I don't see any justification in #1971 for why this particular use case requires a faster stringification than all the other JSON stringification we do in Apollo Server. But just in case this matters to anybody, I went with the fastest possible way of converting a constant object to string.) This should replace #5985.
glasser
added a commit
that referenced
this pull request
Jan 5, 2022
This package was being used only to stringify two small constant objects. It has a major version update available and rather than evaluate the CHANGELOG, we might as well just not use it. (Honestly I think it would be fine to just use JSON.stringify here; I don't see any justification in #1971 for why this particular use case requires a faster stringification than all the other JSON stringification we do in Apollo Server. But just in case this matters to anybody, I went with the fastest possible way of converting a constant object to string.) This should replace #5985.
renovate
bot
changed the title
chore(deps): update dependency fast-json-stringify to v3
chore(deps): update dependency fast-json-stringify to v3 - autoclosed
Jan 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^2.7.6
->^3.0.0
Release Notes
fastify/fast-json-stringify
v3.0.0
Compare Source
What's Changed
New Contributors
Full Changelog: fastify/fast-json-stringify@v2.7.13...v3.0.0
v2.7.13
Compare Source
What's Changed
New Contributors
Full Changelog: fastify/fast-json-stringify@v2.7.12...v2.7.13
v2.7.12
Compare Source
What's Changed
New Contributors
Full Changelog: fastify/fast-json-stringify@v2.7.11...v2.7.12
v2.7.11
Compare Source
What's Changed
New Contributors
Full Changelog: fastify/fast-json-stringify@v2.7.10...v2.7.11
v2.7.10
Compare Source
What's Changed
New Contributors
Full Changelog: fastify/fast-json-stringify@v2.7.9...v2.7.10
v2.7.9
Compare Source
What's Changed
New Contributors
Full Changelog: fastify/fast-json-stringify@v2.7.8...v2.7.9
v2.7.8
Compare Source
What's Changed
New Contributors
Full Changelog: fastify/fast-json-stringify@v2.7.7...v2.7.8
v2.7.7
Compare Source
📚 PR:
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.