Support for graphql@16 #5844
Support for graphql@16 #5844
Conversation
The only change required is in `apollo-server-errors`. But in order to support both graphql@15 and graphql@16 we need to make `ApolloError` a subclass of `GraphQLError`. Bad news it requires `[email protected]` as minimal supported version so I updated `peerDependencies` to that version
| readonly positions: ReadonlyArray<number> | undefined; | ||
| readonly nodes: ReadonlyArray<ASTNode> | undefined; | ||
| public originalError: Error | null | undefined; | ||
| import { GraphQLError, GraphQLFormattedError } from 'graphql'; |
There was a problem hiding this comment.
All the changes happening here, all other changes are just updating peerDependencies.
| super(message); | ||
|
|
||
| // if no name provided, use the default. defineProperty ensures that it stays non-enumerable | ||
| if (!this.name) { |
There was a problem hiding this comment.
Are we losing the "if not" aspect here, or not really because that's not something that really happens?
| // extensions are non enumerable, so copy them directly | ||
| copy.extensions = { | ||
| // merge extensions instead of just copying them | ||
| (copy as any).extensions = { |
There was a problem hiding this comment.
I don't suppose it's possible to avoid as any?
| @@ -35,6 +35,6 @@ | |||
| "apollo-server-integration-testsuite": "file:../apollo-server-integration-testsuite" | |||
| }, | |||
| "peerDependencies": { | |||
| "graphql": "^15.3.0" | |||
| "graphql": "^15.7.1" | |||
There was a problem hiding this comment.
Minor: the PR title would make me expect that this PR would update the peer deps to allow v16! Does it make sense to allow some v16 prereleases explicitly here? Or at least change the PR title to not say it supports graphql@16.
Major: As we discussed, this would seem to require a major version bump of Apollo Server. We haven't even really finished getting everyone to move to AS3 yet; it would be nice to hold off on AS4 for a bit. Is there any way we can brainstorm some sort of alternative that keeps AS3 working with slightly older graphql for a bit?
Generally speaking, do we feel like AS users will find it trivial or challenging to upgrade from v15.3 to v15.7.1? How much app code is likely to change (eg, will users also find that their own GraphQLError implementations need to change)?
There was a problem hiding this comment.
Minor: the PR title would make me expect that this PR would update the peer deps to allow v16! Does it make sense to allow some v16 prereleases explicitly here? Or at least change the PR title to not say it supports graphql@16.
This part is addressed, added 16.0.0 to every peerDependecies
The only change required is in `apollo-server-errors`. Alternative to apollographql#5844
The only change required is in `apollo-server-errors`. Alternative to apollographql#5844
The only change required is in `apollo-server-errors`. Alternative to apollographql#5844
The only change required is in `apollo-server-errors`. Alternative to #5844 Co-authored-by: David Glasser <[email protected]>
The only change required is in
apollo-server-errors.But in order to support both graphql@15 and graphql@16 we need to make
ApolloErrora subclass ofGraphQLError.The bad news is it requires
[email protected]as a minimal supported version so I updatedpeerDependenciesto that version.