Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed typo with experimental_approximateDocumentStoreMiB parameter #4478

Conversation

Arfey
Copy link
Contributor

@Arfey Arfey commented Aug 13, 2020

this parameter didn't use even user specify it. i just initialize it in constructor. Also could u explain this comment:

// Create ~about~ a 30MiB InMemoryLRUCache.  This is less than precise
      // since the technique to calculate the size of a DocumentNode is
      // only using JSON.stringify on the DocumentNode (and thus doesn't account
      // for unicode characters, etc.), but it should do a reasonable job at
      // providing a caching document store for most operations.
Math.pow(2, 20) * (this.experimental_approximateDocumentStoreMiB || 30)

why is it around 30MiB? we have 30 million keys in lru-cache. I'm not sure that it's true (because each key must be equel 1b).

Arfey added 2 commits August 13, 2020 16:34
this parameter didn't use even user specify it. i just initialize it in constructor.
@glasser
Copy link
Member

glasser commented Oct 7, 2022

We fixed this via a different PR (#5629). Sorry for the delay!

@glasser glasser closed this Oct 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants