issue-link js-issue-link" data-error-text="Failed to load title" data-id="376587171" data-permission-text="Title is private" data-url="https://github.com/apollographql/apollo-server/issues/1909" data-hovercard-type="pull_request" data-hovercard-url="/apollographql/apollo-server/pull/1909/hovercard" href="https://github.com/apollographql/apollo-server/pull/1909">#1909]) in order to power its `createTestClient` functionality. This is the testing practice which is documented within [Integration testing] in the Apollo Server documentation. However, it failed to introduce the same context-cloning which [takes place in `runHttpQuery`][Ref 1], prior to arriving at the main request pipeline. Since the context was not cloned, and we had made the expectation in [#3988] that it was a unique context on every single request (which it was, in a non-testing context), the Symbol we use to implement `willResolveField` was already present [on the request pipeline][Ref 2] when running a subsequent test via `createTestClient`! This commit introduces the same cloning that takes place in `buildRequestContext` within `runHttpQuery`, and adds tests to ensure the behavior is preserved. [Fixes #4170]: #4170 [#1909]: #1909 [Integration testing]: https://www.apollographql.com/docs/apollo-server/testing/testing/ [Ref 1]: https://git.io/Jfou6 [#3988]: #3988 [Ref 2]: https://git.io/Jfouy

Commits

Commits on May 28, 2020

server-testing: Ensure user-provided context objects are cloned.

Merge commit 'refs/pull/4064/head' of github.com:apollographql/apollo-server into release-2.14.1

Merge branch 'abernix/fix-executeOperation-context-cloning' into release-2.14.1

Fix typo in comment

Update CHANGELOG.md prior to publishing.

Release