Allow to use @provide with interfaces & Allow to use @extend one fields defined in service different then base #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code was moved to a different repo a few years ago (as described on this comment on a related PR: #3244 (comment)) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is extended version of #3244.
During attempt to add
@providesonReview.productI have founded that I it's impossible to add@externalon Product fields, because Book and Furniture defined in different base services.I removed EXTERNAL_MISSING_ON_BASE validation and some other fixes. All tests except EXTERNAL_MISSING_ON_BASE passed.
So, I don't know why EXTERNAL_MISSING_ON_BASE exists and how to remove is safely. If you show me what is broken now, I will try to fix it.