Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(installSubscriptionHandlers): support passing a WebSocket.Server #1966

Closed
wants to merge 2 commits into from
Closed

fix(installSubscriptionHandlers): support passing a WebSocket.Server #1966

wants to merge 2 commits into from

Conversation

jedwards1211
Copy link
Contributor

@jedwards1211 jedwards1211 commented Nov 14, 2018 •
edited
Loading

fix #1965

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@jedwards1211
Copy link
Contributor Author

Have you guys considered using semantic-release? It would eliminate the manual labor of bumping the version numbers, releasing, and building the changelog.

@abernix
Copy link
Member

abernix commented Apr 22, 2020

Superseded/duplicated by #2314, which has landed.

@abernix abernix closed this Apr 22, 2020
@abernix abernix mentioned this pull request Jun 3, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jedwards1211 @abernix @stevenolay