[2.0] Remove Node dependencies for edge environments #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnwalraven
force-pushed
the
server-2.0/edge-env
branch
from
1a23a36 to
35cbf86
Compare
martijnwalraven
force-pushed
the
server-2.0/edge-env
branch
from
35cbf86 to
16965d3
Compare
This was referenced Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some Node dependencies to allow Apollo Server to run in edge environments like Cloudflare Workers and fly.io.
Because
apollo-upload-serverrequires Node, we only import it when uploads are enabled and don't exportGraphQLUploadfrom theapollo-server-cloudflarepackage. We currently configure bundling for edge to skipapollo-upload-server, but we should find a more principled way to avoid the dependency.