Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: willResolveField and serverWillStop life-cycle hooks. #4104

Closed
abernix opened this issue May 12, 2020 · 1 comment
Closed

docs: willResolveField and serverWillStop life-cycle hooks. #4104

abernix opened this issue May 12, 2020 · 1 comment
Assignees
@abernix
Labels
📝 documentation Focuses on changes to the documentation (docs) 🔌 plugins Relates to the request pipeline plugin API

Comments

@abernix
Copy link
Member

abernix commented May 12, 2020 •
edited by glasser
Loading

We need to write the documentation and update the flow-chart on the plugin documentation with the willResolveField hook that was introduced in #3988 and the serverWillStop hook in #4450. For now, hopefully those PRs themselves (e.g. the example in the description) and the tests that they introduced will serve useful for anyone who wishes to use it.
@abernix abernix added the 📝 documentation Focuses on changes to the documentation (docs) label May 12, 2020
@abernix abernix self-assigned this May 12, 2020
@abernix abernix added the 🔌 plugins Relates to the request pipeline plugin API label May 12, 2020
@abernix abernix mentioned this issue May 12, 2020
Merged
@glasser glasser mentioned this issue Aug 4, 2020
Closed
@glasser glasser changed the title docs: willResolveField life-cycle hook. docs: willResolveField and serverWillStop life-cycle hooks. Aug 21, 2020
@glasser
Copy link
Member

glasser commented Aug 21, 2020

I updated this to mention serverWillStop although it technically has not merged yet.

glasser added a commit that referenced this issue Feb 9, 2021
@glasser
docs: document ApolloServer.stop, serverWillStop, willResolveField
58a1c5f 
v2.20 has two changes related to `stop`, so this is a good time to actually
document it!

Fixes #4104.
glasser added a commit that referenced this issue Feb 9, 2021
@glasser
docs: document ApolloServer.stop, serverWillStop, willResolveField
17adbd2 
v2.20 has two changes related to `stop`, so this is a good time to actually
document it!

Fixes #4104.
@glasser glasser mentioned this issue Feb 9, 2021
Merged
@glasser glasser closed this as completed in dbf22c2 Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abernix abernix

Labels
📝 documentation Focuses on changes to the documentation (docs) 🔌 plugins Relates to the request pipeline plugin API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glasser @abernix