-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please pin 2.0 RC dependencies #1359
Comments
Ah thank you for the issue! Sorry about that. We've pinned the dependencies with #1346. What sort of breaking changes did you experience? I'd like to have that sorted out as well. |
Awesome, thank you. The first was coming off of RC0 to RC6. If I recall correctly, BadUserInputError was renamed to UserInputError. I believe RESTDataSource changed here as well, but don't recall if that was a breaking change. Today we ran into the issue while on RC6. The dataSources function for GraphQLOptions was changed. This required RESTDataSource to extend from DataSource. I was forced to upgrade to RC8 today which also required changing how I start Apollo Server using Express. This also affected the playground url which took a moment to figure out it is using the same route as the graphql queries now. The dependencies that need to be pinned are to projects within the monorepo itself. For example, The ^ needs to be removed from these. |
This is more of a request then anything, but the RC versions of 2.0 have had a few breaking changes and even though I am pinning my versions, the packages themselves are using ^ versions which means when RC 7/8 was pubished, my version of RC6 started using dependencies of RC7/8. This is causing us to have dev down situations until we can update. So my request is for the apollo team to start pinning their dependecies on the RC packages.
Thanks.
The text was updated successfully, but these errors were encountered: