Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please pin 2.0 RC dependencies #1359

Closed
mikebm opened this issue Jul 16, 2018 · 3 comments · Fixed by #1361
Closed

Please pin 2.0 RC dependencies #1359

mikebm opened this issue Jul 16, 2018 · 3 comments · Fixed by #1361

Comments

@mikebm
Copy link

mikebm commented Jul 16, 2018

This is more of a request then anything, but the RC versions of 2.0 have had a few breaking changes and even though I am pinning my versions, the packages themselves are using ^ versions which means when RC 7/8 was pubished, my version of RC6 started using dependencies of RC7/8. This is causing us to have dev down situations until we can update. So my request is for the apollo team to start pinning their dependecies on the RC packages.

Thanks.

@evans
Copy link
Contributor

evans commented Jul 16, 2018

Ah thank you for the issue! Sorry about that. We've pinned the dependencies with #1346. What sort of breaking changes did you experience? I'd like to have that sorted out as well.

@mikebm
Copy link
Author

mikebm commented Jul 16, 2018

Awesome, thank you.

The first was coming off of RC0 to RC6. If I recall correctly, BadUserInputError was renamed to UserInputError. I believe RESTDataSource changed here as well, but don't recall if that was a breaking change.

Today we ran into the issue while on RC6. The dataSources function for GraphQLOptions was changed. This required RESTDataSource to extend from DataSource. I was forced to upgrade to RC8 today which also required changing how I start Apollo Server using Express. This also affected the playground url which took a moment to figure out it is using the same route as the graphql queries now.

The dependencies that need to be pinned are to projects within the monorepo itself.

For example,
https://github.com/apollographql/apollo-server/blob/master/packages/apollo-datasource-rest/package.json#L26

The ^ needs to be removed from these.

@evans
Copy link
Contributor

evans commented Jul 16, 2018

@mikebm Ah! Okay that makes total sense. We've run into issues, such as #1340 and now that you pointed it out, I understand why. Thank you so much! I'll make the necessary changes

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants