Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM version 2.0.0-sashko.0 gets prioritized over all RC versions #1340

Closed
Tehnix opened this issue Jul 12, 2018 · 2 comments
Closed

NPM version 2.0.0-sashko.0 gets prioritized over all RC versions #1340

Tehnix opened this issue Jul 12, 2018 · 2 comments

Comments

@Tehnix
Copy link

Tehnix commented Jul 12, 2018

NPM doesn't handle -beta, -rc or similar in any special way, meaning that because s comes after r in the alphabet, 2.0.0-sashko.0 is interpreted as a newer version than 2.0.0-rc.7, which is the latest version.

The list here https://www.npmjs.com/package/apollo-server-lambda lists the versions by date, but in NPM/Yarn it will fetch it by version number.

So, if you have a version pinning of ^2.0.0-rc.7 you will currently get 2.0.0-sashko.0 instead of the RCs.

Running yarn upgrade apollo-server@bla (to force the list of versions) will get you the following list,

❯ 2.0.0-sashko.0
  2.0.0-rc.7
  2.0.0-rc.6
  2.0.0-rc.5
  2.0.0-rc.4
  2.0.0-rc.3
  2.0.0-rc.2.1
  2.0.0-rc.2
  2.0.0-rc.1
  2.0.0-beta.9
  2.0.0-beta.8

Solution: You should probably delete 2.0.0-sashko.0 to avoid others getting their builds broken.

@evans
Copy link
Contributor

evans commented Jul 13, 2018

@Tehnix Ah that's an unexpected behavior for sure. Thank you for pointing it out! We'll be sure to make the next release work alphabetically

@evans
Copy link
Contributor

evans commented Jul 16, 2018

@Tehnix Thanks we've fixed this by publishing [email protected]

@evans evans closed this as completed Jul 16, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants