Undo defensive code for internalFragments, it's not needed after all

apollographql · Feb 19, 2020 · e77895d · e77895d
1 parent 2e126fc
commit e77895d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/apollo-gateway/src/QueryPlan.ts b/packages/apollo-gateway/src/QueryPlan.ts
@@ -41,7 +41,7 @@ export interface FetchNode {
   selectionSet: SelectionSetNode;
   variableUsages?: { [name: string]: VariableDefinitionNode };
   requires?: SelectionSetNode;
-  internalFragments?: Set<FragmentDefinitionNode>;
+  internalFragments: Set<FragmentDefinitionNode>;
 }
 export interface FlattenNode {
   kind: 'Flatten';

diff --git a/packages/apollo-gateway/src/executeQueryPlan.ts b/packages/apollo-gateway/src/executeQueryPlan.ts
@@ -498,7 +498,7 @@ function operationForRootFetch(
         selectionSet: fetch.selectionSet,
         variableDefinitions: mapFetchNodeToVariableDefinitions(fetch),
       },
-      ...(fetch.internalFragments || []),
+      ...fetch.internalFragments,
     ],
   };
 }
@@ -557,7 +557,7 @@ function operationForEntitiesFetch(fetch: FetchNode): DocumentNode {
           ],
         },
       },
-      ...(fetch.internalFragments || [])
+      ...fetch.internalFragments
     ],
   };
 }

diff --git a/packages/apollo-gateway/src/snapshotSerializers/queryPlanSerializer.ts b/packages/apollo-gateway/src/snapshotSerializers/queryPlanSerializer.ts
@@ -71,7 +71,7 @@ function printNode(
         ) +
         config.spacingOuter +
         indentation +
-        (node.internalFragments && node.internalFragments.size > 0
+        (node.internalFragments.size > 0
           ? '  ' +
             Array.from(node.internalFragments)
               .map(fragment =>