Skip to content

Commit

Permalink
Add start calls to docs where necessary
Browse files Browse the repository at this point in the history 
Don't add it for serverless because we don't do that as of today

Need to investigate micro still (is it sync-only like serverless?) and write
actual docs.
  • Loading branch information
@glasser
glasser committed Mar 18, 2021
1 parent 69cb6f0 commit 5aee90c
Show file tree
Hide file tree
Showing 14 changed files with 12 additions and 29 deletions.
2 changes: 1 addition & 1 deletion docs/source/data/subscriptions.mdx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ const express = require('express');
const PORT = 4000;
const app = express();
const server = new ApolloServer({ typeDefs, resolvers });
// FIXME start
await server.start();
server.applyMiddleware({app})

const httpServer = http.createServer(app);
Expand Down
1 change: 0 additions & 1 deletion docs/source/deployment/azure-functions.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ const resolvers = {
};

const server = new ApolloServer({ typeDefs, resolvers });
// FIXME start
exports.graphqlHandler = server.createHandler();
```

Expand Down
4 changes: 0 additions & 4 deletions docs/source/deployment/lambda.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ const resolvers = {
};

const server = new ApolloServer({ typeDefs, resolvers });
// FIXME start

exports.graphqlHandler = server.createHandler();
```
Expand Down Expand Up @@ -165,7 +164,6 @@ const server = new ApolloServer({
context,
}),
});
// FIXME start

exports.graphqlHandler = server.createHandler();
```
Expand All @@ -192,7 +190,6 @@ const resolvers = {
};

const server = new ApolloServer({ typeDefs, resolvers });
// FIXME start

exports.graphqlHandler = server.createHandler({
cors: {
Expand Down Expand Up @@ -222,7 +219,6 @@ const resolvers = {
};

const server = new ApolloServer({ typeDefs, resolvers });
// FIXME start

exports.graphqlHandler = server.createHandler({
cors: {
Expand Down
1 change: 0 additions & 1 deletion docs/source/deployment/netlify.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ const server = new ApolloServer({
typeDefs,
resolvers
});
// FIXME start

exports.handler = server.createHandler();
```
Expand Down
2 changes: 1 addition & 1 deletion docs/source/integrations/middleware.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const server = new ApolloServer({
typeDefs,
resolvers,
});
// FIXME start
await server.start();

server.applyMiddleware({ app });

Expand Down
2 changes: 1 addition & 1 deletion docs/source/security/terminating-ssl.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const environment = process.env.NODE_ENV || 'production'
const config = configurations[environment]

const apollo = new ApolloServer({ typeDefs, resolvers })
// FIXME start
await apollo.start()

const app = express()
apollo.applyMiddleware({ app })
Expand Down
3 changes: 0 additions & 3 deletions packages/apollo-server-azure-functions/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ const resolvers = {
};

const server = new ApolloServer({ typeDefs, resolvers });
// FIXME start

module.exports = server.createHandler();
```
Expand Down Expand Up @@ -87,7 +86,6 @@ const server = new ApolloServer({
typeDefs,
resolvers,
});
// FIXME start

module.exports = server.createHandler({
cors: {
Expand Down Expand Up @@ -120,7 +118,6 @@ const server = new ApolloServer({
typeDefs,
resolvers,
});
// FIXME start

module.exports = server.createHandler({
cors: {
Expand Down
4 changes: 0 additions & 4 deletions packages/apollo-server-cloud-functions/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ const server = new ApolloServer({
playground: true,
introspection: true,
});
// FIXME start

exports.handler = server.createHandler();
```
Expand Down Expand Up @@ -83,7 +82,6 @@ const server = new ApolloServer({
res,
}),
});
// FIXME start

exports.handler = server.createHandler();
```
Expand Down Expand Up @@ -113,7 +111,6 @@ const server = new ApolloServer({
typeDefs,
resolvers,
});
// FIXME start

exports.handler = server.createHandler({
cors: {
Expand Down Expand Up @@ -146,7 +143,6 @@ const server = new ApolloServer({
typeDefs,
resolvers,
});
// FIXME start

exports.handler = server.createHandler({
cors: {
Expand Down
4 changes: 2 additions & 2 deletions packages/apollo-server-express/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const resolvers = {
};

const server = new ApolloServer({ typeDefs, resolvers });
// FIXME start
await server.start();

const app = express();
server.applyMiddleware({ app });
Expand Down Expand Up @@ -70,7 +70,7 @@ const resolvers = {
};

const server = new ApolloServer({ typeDefs, resolvers });
// FIXME start
await server.start();

const app = connect();
const path = '/graphql';
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-fastify/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ const server = new ApolloServer({
typeDefs,
resolvers,
});
// FIXME start

const app = require('fastify')();

(async function () {
await server.start();
app.register(server.createHandler());
await app.listen(3000);
})();
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-hapi/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const Hapi = require('hapi');

async function StartServer() {
const server = new ApolloServer({ typeDefs, resolvers });
// FIXME start
await server.start();

const app = new Hapi.server({
port: 4000
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-koa/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const resolvers = {
};

const server = new ApolloServer({ typeDefs, resolvers });
// FIXME start
await server.start();

const app = new Koa();
server.applyMiddleware({ app });
Expand Down
4 changes: 0 additions & 4 deletions packages/apollo-server-lambda/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ const server = new ApolloServer({
playground: true,
introspection: true,
});
// FIXME start

exports.handler = server.createHandler();
```
Expand Down Expand Up @@ -136,7 +135,6 @@ const server = new ApolloServer({
context,
}),
});
// FIXME start

exports.handler = server.createHandler();
```
Expand Down Expand Up @@ -166,7 +164,6 @@ const server = new ApolloServer({
typeDefs,
resolvers,
});
// FIXME start

exports.handler = server.createHandler({
cors: {
Expand Down Expand Up @@ -199,7 +196,6 @@ const server = new ApolloServer({
typeDefs,
resolvers,
});
// FIXME start

exports.handler = server.createHandler({
cors: {
Expand Down
8 changes: 4 additions & 4 deletions packages/apollo-server-micro/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const resolvers = {
};

const apolloServer = new ApolloServer({ typeDefs, resolvers });
// FIXME start
await server.start();
module.exports = apolloServer.createHandler();
```

Expand Down Expand Up @@ -87,7 +87,7 @@ const resolvers = {
};

const apolloServer = new ApolloServer({ typeDefs, resolvers });
// FIXME start
await server.start();
const handler = apolloServer.createHandler(); // highlight-line
module.exports = cors((req, res) => req.method === 'OPTIONS' ? res.end() : handler(req, res)) // highlight-line
```
Expand Down Expand Up @@ -139,7 +139,7 @@ const resolvers = {
};

const apolloServer = new ApolloServer({ typeDefs, resolvers });
// FIXME start
await server.start();
module.exports = apolloServer.createHandler({ path: '/data' }); // highlight-line
```

Expand Down Expand Up @@ -192,7 +192,7 @@ const resolvers = {
};
const apolloServer = new ApolloServer({ typeDefs, resolvers });
// FIXME start
await server.start();
const graphqlPath = '/data';
const graphqlHandler = apolloServer.createHandler({ path: graphqlPath });
module.exports = router(
Expand Down

0 comments on commit 5aee90c

Please sign in to comment.