Fix persistedQueries to pull graphqlErrors from networkErrors #9410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@redaid113: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
We're having this same problem as well, would love to see this get merged! |
benjamn
force-pushed
the
persisted-query-graphqlError-bug
branch
from
3135cb2 to
aed6e97
Compare
benjamn
approved these changes
May 2, 2022
There was a problem hiding this comment.
Thanks for implementing this improvement and including tests @redaid113!
I made a few additional changes that you are welcome to review at your convenience.
|
Thanks for those changes and reviewing this @benjamn |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes an issue with persistedQueries.
Servers can contain graphQLErrors, but was missing in persistedQueries. If a server returned a 400 with a 'PersistedQueryNotFound' error message, it would be treated as a networkError and disable persistedQueries.
Checklist: