Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6557 - Fix slow down on multiple fetchMore #8920

Closed
wants to merge 1 commit into from

Conversation

bendenoz
Copy link
Contributor

Having a go at this.

Default fetch policy for fetchMore creates many unreleased cache watches.
The cache is managed in the updateQuery callback anyway, so there should not be a need for network-only in fetchMore.

This seems to fix slowdowns for our use case

@benjamn
Copy link
Member

benjamn commented Oct 13, 2021

@bendenoz This has been fixed for a long time (since #6221, or @apollo/[email protected], or any non-prerelease version of the @apollo/client package). What's preventing you from updating, out of curiosity?

@bendenoz
Copy link
Contributor Author

Thanks for your reply @benjamn, I'm always a bit wary about big upgrades on a production project, but I guess we will try now.
And #6557 is still somehow active so I assumed the issue was still around.

@bendenoz
Copy link
Contributor Author

ok it's working fine with apollo 3 so we're in the process of upgrading.
thanks !

@bendenoz bendenoz closed this Oct 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants