-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore TypedArrays when freezing object #8813
Conversation
@geekuillaume: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
@benjamn This looks good to me! Though perhaps you have a more comprehensive solution including more edge cases. |
Like said in my previous comment #6813 (comment), we could just ignore errors when applying |
@geekuillaume @brainkim I agree we should err on the side of silencing all possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started @geekuillaume! Since I assigned #6813 to myself, you technically did (most of) my job for me—much appreciated.
Checklist:
This PR fixes #6813 by ignored TypedArrays when freezing objects.