Report single MissingTree instead of large MissingFieldError[] array for incomplete cache reads
#8734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this comment I confirmed that this PR fixes my issue: #8707 (comment). Thanks again! |
benjamn
force-pushed
the
issue-8707-MissingFieldError-performance
branch
from
0125b55 to
4203a8a
Compare
brainkim
reviewed
Sep 17, 2021
brainkim
reviewed
Sep 17, 2021
| @@ -241,6 +230,7 @@ export class StoreReader { | |||
| }; | |||
|
|
|||
| const rootRef = makeReference(rootId); | |||
| const merger = new DeepMerger; | |||
There was a problem hiding this comment.
I thought TypeScript hated it when you invoke a constructor without parens.
There was a problem hiding this comment.
Can we get a comment about why we’re using DeepMerger directly over calling mergeDeep? Is there some kind of stateful thing going on here?
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the (somewhat pathological but also entirely plausible) example in #8707, more than 60% of cache read time is spent creating
MissingFieldErrorobjects, in part because an unnecessaryInvariantErroris created and then used only for itsmessage; in part because theMissingFieldErrorclass inherits fromError, which makessuper(message)initialization expensive; but also (in large part) because there are just so many error objects (tens of thousands).This pull request needs more work to minimize breaking changes for anyone using the
MissingFieldErrortype directly, but it offers an extremely appealing solution to the performance problems enumerated above: What if we reported only one, combinedMissingFieldErrorper cache read?On a personal note, I'm leaving for a weeklong vacation today, so I don't need this reviewed any time soon. 🏝