Cancel the pending notify timeout when stopping a query #7935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
stop
method does not clear the pendingnotifyTimeout
. When a query is stopped in the same tick and right after a cache update sets thenotifyTimeout
, the query is not removed correctly, as thenotifyTimeout
callback will recreate theQueryInfo
. This might lead to undesired behavior, as queries are executed that should have been stopped already.I could not find a suitable test to extend / was unsure how to add a new test for this.
Might be related to #6888
Checklist: