Edits to reading and writing cached data #7864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenBarlow
force-pushed
the
sb/cache-interaction-tweaks
branch
from
e381a70 to
de12147
Compare
StephenBarlow
force-pushed
the
sb/cache-interaction-tweaks
branch
from
de12147 to
a8ec20c
Compare
StephenBarlow
force-pushed
the
sb/cache-interaction-tweaks
branch
from
243b412 to
120b108
Compare
benjamn
approved these changes
Mar 23, 2021
Comment on lines
280
to
287
| ```json | ||
| { | ||
| "data": { | ||
| "allPeople": { | ||
| "people": [ | ||
| { | ||
| "id": "cGVvcGxlOjE=", | ||
| "name": "Luke Skywalker", |
There was a problem hiding this comment.
Can we add the __typename: "Person" (and "Planet") fields to this data, and add a note about Apollo Client automatically adding those fields to the query? Otherwise it may be hard to understand how the normalization makes use of the __typename information.
| const { todo } = client.readQuery({ | ||
| { | ||
| todo: { | ||
| __typename: 'Todo', // __typename is automatically included |
There was a problem hiding this comment.
Similar to my previous comment, it might be good to explain how __typename gets automatically included?
| @@ -149,12 +224,14 @@ client.writeQuery({ | |||
| }); | |||
| ``` | |||
|
|
|||
| ## `cache.modify` | |||
| ## Using `cache.modify` | |||
|
|
|||
| The `modify` method of `InMemoryCache` enables you to directly modify the values of individual cached fields, or even delete fields entirely. | |||
|
|
|||
| * Like `writeQuery` and `writeFragment`, `modify` triggers a refresh of all active queries that depend on modified fields (unless you override this behavior). | |||
There was a problem hiding this comment.
Suggested change
| * Like `writeQuery` and `writeFragment`, `modify` triggers a refresh of all active queries that depend on modified fields (unless you override this behavior). | |
| * Like `writeQuery` and `writeFragment`, `modify` triggers a refresh of all active queries that depend on modified fields (unless you override this behavior by passing `broadcast: false`). |
Not critical, but I'm assuming this is what was originally meant by "override this behavior."
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.