Migrate all React Apollo SSR features into Apollo Client #6499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the `react-apollo` projects `@apollo/react-ssr` features into this project. This will help us discontinue the `react-apollo` project sooner than later.
This keeps React SSR features out of the main bundle. React SSR can be accessed through the separate `@apollo/client/react/ssr` entry point.
benjamn
approved these changes
Jun 30, 2020
| * @apollo/client/core | ||
| * @apollo/client/cache | ||
| * @apollo/client/utilities | ||
| * @apollo/client/react/ssr |
There was a problem hiding this comment.
Given that @apollo/client/react/ssr is currently the only subdirectory entry point within @apollo/client/react, I would love to see @apollo/client/react/components and @apollo/client/react/hoc added as well!
|
@benjamn . How would you import something like This particular code snippet: I'm on |
This was referenced Jul 15, 2020
benjamn
pushed a commit
that referenced
this pull request
Jul 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all
@apollo/react-ssrfunctionality out of the https://github.com/apollographql/react-apollo repo, into this project. SSR features are kept out of the main@apollo/clientbundle, and are instead reachable through the@apollo/client/react/ssrentry point.