Fix Resolver type #4943
Merged
Fix Resolver type #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 11, 2019 08:50
The exported type for Resolve differs from Resolvers. This causes some type errors when trying to type your resolvers. Where we call the resolver we only use the indicated parameters (fieldName never gets passed to the resolver, e.g https://github.com/apollographql/apollo-client/blob/master/packages/apollo-client/src/core/LocalState.ts#L391). Also it is aligned with the GraphQL Resolver API
|
@peoplenarthax: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
Anybody ? |
|
@hwillson , any suggestion in how to move this? Has been here since June the 11th |
hwillson
approved these changes
Sep 4, 2019
There was a problem hiding this comment.
Great catch and change @peoplenarthax! fieldName was left over from some previous refactoring, so thanks for cleaning that up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match Resolver and Resolvers
The exported type for Resolve differs from Resolvers. This causes some type errors when trying to type your resolvers.
Where we call the resolve we only use the indicated parameters (fieldName never gets passed first to the Resolver, e.g https://github.com/apollographql/apollo-client/blob/master/packages/apollo-client/src/core/LocalState.ts#L391).
Also it is aligned with the GraphQL Resolver API.
Note: Not sure if this was intentional, if so just ignore this PR (even tho an explanation is welcome so I can understand better the type), but it feels like there is a misalignment around the types and if they are already fluffy (any, any, any), this inconsistency make it more difficult to type resolvers.
Checklist: