Additional check for this.store to prevent undefined error at this.store[o].networkStatus=t.NetworkStatus.ready #3914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is necessary, because sometimes a component gets mounted, request is fired, then the component gets unmounted (perhaps by user) and
this.store
becomesundefined
, which causes the request handling to fail atthis.store[queryId].networkStatus = complete
withundefined is not an object
, as we only checkif (!this.store[queryId]) return;
but instead we should checkif (!this.store || !this.store[queryId]) return;