Corrected ApolloClient.queryManager typing as it may be undefined #3661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in apollographql/react-apollo#2164 that
ApolloClient.queryManager
can actually be undefined as it is lazily initialised. This PR corrects the typing to reflect this. I chose to modelinitQueryManager
afterinitProxy
as this pattern was already being used. I also considered adding a getter forqueryManager
to initialise it whenever called, but rejected it to keep the pattern of actively having to init theQueryManager
.// cc @rosskevin