-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/remove unused @client meta #3482
Feature/remove unused @client meta #3482
Conversation
…tadata, such as variables and fragment spreads. Added test coverage for the individual features (get/remove arguments/fragment spreads) as well as the integration point.
Trying to get |
Generated by 🚫 dangerJS |
Thanks for submitting this PR @justinmakaila! Unfortunately, this isn't something we're ready to accept. The changes you're proposing are fairly significant and have far reaching affects across the |
Re-opening this to take another look (as discussed with @justinmakaila via Slack). |
Codecov Report
@@ Coverage Diff @@
## master #3482 +/- ##
=========================================
- Coverage 89.13% 85.3% -3.83%
=========================================
Files 47 41 -6
Lines 2679 2573 -106
Branches 609 609
=========================================
- Hits 2388 2195 -193
- Misses 274 370 +96
+ Partials 17 8 -9
Continue to review full report at Codecov.
|
Sorry for the long delay here @justinmakaila. We're working on a new version of |
…used-@client-meta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for working on this @justinmakaila! Sorry for the long delay in getting this reviewed. LGTM! 👍
YESSSSSSS |
Checklist:
In reference to #3475... Wish I could say a consensus was reached, but there was no activity for days and this is mission critical stuff... the client is currently spitting out invalid queries after manipulating the operations...