Batching/scheduling #278

Poincare · 2016-06-11T00:38:48Z

This PR (originally part of PR #266) implements the logic that allows for queries to be batched together automatically. It is still WIP and I will now be implementing the changes as discussed with @helfer.

TODO:

Update CHANGELOG.md with your change
Make sure all of the significant new logic is covered by tests
Rebase your changes on master so that they can be merged easily
Make sure all tests and linter rules pass

helfer · 2016-06-17T19:33:42Z

Can you rebase this on top of master now that the other PR is merged? It looks like they have some overlap now.

stubailo · 2016-06-18T15:00:52Z

I assume the reason it's done as part of the network interface is because when we build batching at the transport level, we'll want to have a special network interface for that transport?

helfer · 2016-06-18T16:26:58Z

Yes, the idea is that different servers may not all support the same kind of batching. There's a "batcher" in the client that batches up requests and sends them to the network interface at the same time, but it's up to the network interface to decide whether it sends the queries batched or not.

Scheduling for polling queries is going to be another separate module, which just aligns polling intervals.

stubailo · 2016-06-20T22:11:28Z

src/batching.ts

+
+  public start(pollInterval: Number) {
+    this.pollInterval = pollInterval;
+    this.pollTimer = setInterval(() => {


Does this setInterval even use the pollInterval? Or am I missing something?

good catch - I'm not sure what happened there

Poincare · 2016-06-21T04:01:51Z

Fixed @stubailo

…ueue mechanism

…eave in queue

…diately

…rkInterface

…ked network interface

…only polling queries

…ager

…atch: false

stubailo · 2016-06-21T22:59:28Z

src/QueryManager.ts

+      queryManager: this,
+    });
+    this.batcher = new QueryBatcher({
+      //we batch if the network interface supports batching if user has not specified


This comment is not correct

Update all dependencies 🌴

Query docs: PropTypes is now a separate package

…ling Batching/scheduling

zol added the in progress label Jun 11, 2016

Poincare force-pushed the batching_scheduling branch from f1eae52 to be178d6 Compare June 11, 2016 00:39

Poincare mentioned this pull request Jun 11, 2016

WIP: Request batching #266

Closed

4 tasks

zol assigned Poincare Jun 14, 2016

Poincare force-pushed the batching_scheduling branch from 943a109 to 6672fa8 Compare June 15, 2016 00:47

Poincare changed the title ~~WIP: Batching/scheduling~~ Batching/scheduling Jun 15, 2016

Poincare force-pushed the batching_scheduling branch from 6672fa8 to a640c27 Compare June 20, 2016 19:26

stubailo reviewed Jun 20, 2016
View reviewed changes

Poincare force-pushed the batching_scheduling branch from df6c746 to d6ce369 Compare June 21, 2016 22:35

stubailo force-pushed the batching_scheduling branch from d6ce369 to 33669b6 Compare June 21, 2016 22:40

Poincare added 12 commits June 21, 2016 15:40

in progress commit for query batching

a7e2977

first commit toward batching support. implementing the 'scheduling' q…

bc35b8e

…ueue mechanism

working on fixing the polling mechanism

809205e

added implementation of "one query in flight" + unit tests for the same

123f230

refactored some of the stuff that decides what to fetch and what to l…

c450116

…eave in queue

refactored more and added a thing that fires non-batched queries imme…

c42bca1

…diately

refactoring QueryManager slightly

a256b48

in progress commit for fetchBatchedeQuery

f268375

implemented fetchBatchQueries and added the concept of a BatchedNetwo…

2a384cb

…rkInterface

added a test that checks if queries can be batched correctly on a moc…

f59197b

…ked network interface

moved the scheduling mechanism to its own file and it now deals with …

4b3faf6

…only polling queries

added scheduler test module

5d3bc10

Poincare and others added 16 commits June 21, 2016 15:40

added tests for batching on QueryManager

e3a704a

all tests passing with scheduler and batcher integrated into QueryMan…

ec0a155

…ager

Removed and refactored some of the stuff in QueryManager

d6541ae

renamed stuff that refered to the batcher as the scheduler

9e68de3

made the changes listed in the PR we split up

224191f

tests passing

0696cf9

fixed the rogue aliasName test

0e0989e

fixed filesize note

bdc8c79

removed useless file

f9560d7

removed fetchBatchedQueries which the rebase somehow included back in

8009e46

updated changelog and improved test coverage

afa647a

removed buffer file

c0af195

fixes within the batching code and tests for it

581c931

fixed query manager typecheck and made the batcher a NOP when shouldB…

654c703

…atch: false

made batching not on by default

4082890

Reorg changelog

33669b6

stubailo force-pushed the batching_scheduling branch from 4461e86 to 9bd9996 Compare June 21, 2016 22:56

Poincare added 2 commits June 21, 2016 15:57

fixing this undefined thing

f9ccf75

fixed undefined issue

9bd9996

stubailo reviewed Jun 21, 2016
View reviewed changes

stubailo assigned stubailo and unassigned Poincare Jun 21, 2016

Remove incorrect comment

cb6da55

stubailo merged commit 3ab90b2 into master Jun 21, 2016

zol removed the in progress label Jun 21, 2016

stubailo deleted the batching_scheduling branch September 20, 2016 03:41

jbaxleyiii pushed a commit that referenced this pull request Oct 17, 2017

Merge pull request #278 from apollographql/greenkeeper-update-all

b759d88

Update all dependencies 🌴

jbaxleyiii pushed a commit that referenced this pull request Oct 18, 2017

Merge pull request #278 from staylor/patch-2

02aeb1c

Query docs: PropTypes is now a separate package

LevanArabuli pushed a commit to LevanArabuli/apollo-client that referenced this pull request Nov 3, 2022

Merge pull request apollographql#278 from apollostack/batching_schedu…

9c43030

…ling Batching/scheduling

github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Batching/scheduling #278

Batching/scheduling #278

Poincare commented Jun 11, 2016 •

edited by stubailo

Loading

helfer commented Jun 17, 2016

stubailo commented Jun 18, 2016

helfer commented Jun 18, 2016

stubailo Jun 20, 2016

Poincare Jun 20, 2016

Poincare commented Jun 21, 2016 •

edited

Loading

stubailo Jun 21, 2016

Batching/scheduling #278

Batching/scheduling #278

Conversation

Poincare commented Jun 11, 2016 • edited by stubailo Loading

helfer commented Jun 17, 2016

stubailo commented Jun 18, 2016

helfer commented Jun 18, 2016

stubailo Jun 20, 2016

Choose a reason for hiding this comment

Poincare Jun 20, 2016

Choose a reason for hiding this comment

Poincare commented Jun 21, 2016 • edited Loading

stubailo Jun 21, 2016

Choose a reason for hiding this comment

Poincare commented Jun 11, 2016 •

edited by stubailo

Loading

Poincare commented Jun 21, 2016 •

edited

Loading