-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flow-types to library level #1820
Add flow-types to library level #1820
Conversation
+1 |
I tested this in our fairly big project. Fixed a few errors. For example Also I changed |
Btw But I'm not sure if something like this won't introduce a breaking change because |
I'll leave this to @jbaxleyiii to look at soon! |
@michalkvasnicak I'll take a look at this today! I agree that breaking it apart would be much better! We talked about doing it the first time around but opted to ship it as an enhancement / make it optional in order to get feedback from users like yourself! Thank you so much for the work on this! I'll review it and report back today! |
@michalkvasnicak are you using react-apollo as well? It would be great to do the same setup there if you don't mind! |
@michalkvasnicak great work! Thank you so much for this! |
@michalkvasnicak this is great! If you could update the changelog, I'll merge it in and it can be part of the next release! |
@jbaxleyiii I don't use |
@michalkvasnicak thank you again for this! It will be released as 1.8! |
This PR adds support for flow type without need to configure
.flowconfig
in a project.It's basically the same as in apollographql/graphql-tag#97.
This is good for library authors too, for example I wanted to typecheck in my library react-apollo-graphql but I didn't want to force users to configure their
.flowconfig
just to typecheck apollo-client's stuff. So I made my own typings.With this PR I can get rid of my own types and use yours :)
Closes #1819