Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping graphql-tag, ignoring deprecation warnings #1356

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

jnwng
Copy link
Contributor

@jnwng jnwng commented Mar 2, 2017

graphql-tag has deprecated the export of the printer export (which we use for various AST-related tasks here in apollo-client). when graphql-tag@v2 comes out, we can switch to using the printer / parser from the graphql package, but for now we know about the deprecation warning and can safely ignore it.

addresses graphql-tag#54

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

`graphql-tag` has deprecated the export of the `printer` export (which we use for various AST-related tasks here in `apollo-client`). when `graphql-tag@v2` comes out, we can switch to using the printer / parser from the `graphql` package, but for now we know about the deprecation warning and can safely ignore it.
@helfer helfer merged commit 84db802 into apollographql:master Mar 3, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants