Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onCompleted and onError callbacks from useQuery and useLazyQuery #12359

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

jerelmiller
Copy link
Member

Related to #12352

Removes the onCompleted and onError callbacks from useQuery and useLazyQuery deprecated in 3.13.

See #12352 for more context on this change.

@jerelmiller jerelmiller requested a review from phryneas February 7, 2025 22:26
Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 538c452

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svc-apollo-docs
Copy link

svc-apollo-docs commented Feb 7, 2025

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch release-4.0 is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch version-2.6
  • !docs set-base-branch main

Build ID: 5bef90ff15c34b0655c320b0

Copy link

pkg-pr-new bot commented Feb 7, 2025

npm i https://pkg.pr.new/@apollo/client@12359

commit: 8cd65f7

Copy link
Contributor

github-actions bot commented Feb 7, 2025

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 33.47 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 41.43 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 38.73 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.16 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.57 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 4.95 KB (-3.64% 🔽)
import { useQuery } from "dist/react/index.js" (production) 4.05 KB (-4.1% 🔽)
import { useLazyQuery } from "dist/react/index.js" 5.45 KB (-3.04% 🔽)
import { useLazyQuery } from "dist/react/index.js" (production) 4.53 KB (-3.54% 🔽)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.44 KB (+0.03% 🔺)
import { useSubscription } from "dist/react/index.js" (production) 3.49 KB (+0.03% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" 5.52 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.18 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.65 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.08 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.73 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.4 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.35 KB (0%)
import { useFragment } from "dist/react/index.js" 2.01 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 1.95 KB (0%)

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 538c452
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/67aa4e3de4b66800077f0867
😎 Deploy Preview https://deploy-preview-12359--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the auto-cleanup 🤖 label Feb 10, 2025
@jerelmiller jerelmiller force-pushed the jerel/remove-callbacks branch from 735f5fb to 8cd65f7 Compare February 10, 2025 19:04
@jerelmiller jerelmiller merged commit ebb4d96 into release-4.0 Feb 10, 2025
37 checks passed
@jerelmiller jerelmiller deleted the jerel/remove-callbacks branch February 10, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants