Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky useQuery test #12323

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix flaky useQuery test #12323

merged 1 commit into from
Jan 30, 2025

Conversation

jerelmiller
Copy link
Member

Tries to fix one of the flaky tests that check for the number of requests by switching to fake timers.

Copy link

changeset-bot bot commented Jan 30, 2025

⚠️ No Changeset found

Latest commit: e8da980

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-apollo-docs
Copy link

svc-apollo-docs commented Jan 30, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: e5b271e610c8bc762454ecc4

@jerelmiller jerelmiller requested a review from phryneas January 30, 2025 02:43
Copy link

pkg-pr-new bot commented Jan 30, 2025

npm i https://pkg.pr.new/@apollo/client@12323

commit: e8da980

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit e8da980
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/679ae7660c29f50008bcf6f9
😎 Deploy Preview https://deploy-preview-12323--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.67 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.08 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.19 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.18 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.58 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.29 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.7 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.35 KB (0%)
import { useFragment } from "dist/react/index.js" 2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.31 KB (0%)

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it ran without flaking, let's give it a chance!

@phryneas phryneas merged commit 5ae1215 into main Jan 30, 2025
48 checks passed
@github-actions github-actions bot added the auto-cleanup 🤖 label Jan 30, 2025
@jerelmiller jerelmiller deleted the jerel/attempt-flaky-test-fix branch January 30, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants